Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Inject annotations, swap to jakarta for nonnull #372

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Remove use of Inject annotations, swap to jakarta for nonnull #372

merged 3 commits into from
Nov 1, 2023

Conversation

JPercival
Copy link
Contributor

  • remove use of Inject annotations
  • change JavaX annotations to Jakarta for Nonnull
    • used at compile time only, so no implications for runtime.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Formatting check succeeded!

@JPercival JPercival enabled auto-merge (squash) October 31, 2023 21:08
@JPercival JPercival requested review from mdnazmulkarim, barhodes and lukedegruchy and removed request for barhodes October 31, 2023 21:08
@JPercival JPercival merged commit 3e48289 into master Nov 1, 2023
3 checks passed
@JPercival JPercival deleted the feature-jakarta branch November 1, 2023 13:33
@JPercival JPercival mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedegruchy lukedegruchy lukedegruchy approved these changes

@barhodes barhodes barhodes approved these changes

@mdnazmulkarim mdnazmulkarim Awaiting requested review from mdnazmulkarim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JPercival @lukedegruchy @barhodes