Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ErrorProne and CheckStyle #404

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Enable ErrorProne and CheckStyle #404

merged 6 commits into from
Jan 18, 2024

Conversation

JPercival
Copy link
Contributor

@JPercival JPercival commented Jan 17, 2024

  • Enable ErrorProne

    • Fixes for all errors
    • Warnings disabled for now, will revisit in the future
  • Enable CheckStyle for Google naming conventions

    • Palantir format already enforced by spotless
    • We were starting to mix HAPI conventions into the codebase, sometimes within the same class and even using different conventions for different method parameters
    • Fixes for all cases using HAPI conventions, resetting to Google conventions

    Resolves Enable ErrorProne for the build #405

@JPercival JPercival changed the title Feature code quality Enable ErrorProne and CheckStyle Jan 17, 2024
Copy link

Formatting check succeeded!

Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are still issues in the benchmark package. Changes all look good to me, though.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 715 lines in your changes are missing coverage. Please review.

Comparison is base (3c03d02) 43.36% compared to head (e13da44) 43.36%.

Files Patch % Lines
...ncds/cqf/fhir/cr/measure/r4/R4CareGapsService.java 0.00% 103 Missing ⚠️
...s/cqf/fhir/utility/builder/CompositionBuilder.java 0.00% 61 Missing ⚠️
.../cqf/fhir/utility/builder/BaseResourceBuilder.java 0.00% 54 Missing ⚠️
.../opencds/cqf/fhir/utility/dstu3/PackageHelper.java 0.00% 53 Missing ⚠️
...org/opencds/cqf/fhir/utility/r4/PackageHelper.java 0.00% 53 Missing ⚠️
...org/opencds/cqf/fhir/utility/r5/PackageHelper.java 0.00% 53 Missing ⚠️
...ty/builder/CompositionSectionComponentBuilder.java 0.00% 40 Missing ⚠️
...ir/utility/builder/BaseBackboneElementBuilder.java 0.00% 33 Missing ⚠️
...cqf/fhir/utility/builder/DetectedIssueBuilder.java 0.00% 33 Missing ⚠️
...a/org/opencds/cqf/fhir/utility/client/Clients.java 47.16% 25 Missing and 3 partials ⚠️
... and 31 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #404      +/-   ##
============================================
- Coverage     43.36%   43.36%   -0.01%     
  Complexity     1627     1627              
============================================
  Files           224      224              
  Lines         11781    11773       -8     
  Branches       1653     1649       -4     
============================================
- Hits           5109     5105       -4     
+ Misses         6051     6048       -3     
+ Partials        621      620       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit b0deb9e into master Jan 18, 2024
6 checks passed
@JPercival JPercival deleted the feature-code-quality branch January 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ErrorProne for the build
2 participants