Move CRMI operations to Visitors #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/TahaAttari/clinical-reasoning into knowledge-artifact-visitors-adapters
TahaAttari
commented
Feb 21, 2024
Comment on lines
+80
to
+82
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
use this to test WARN level logging
add missing Extension generic params per suggestion Co-authored-by: Brenin Rhodes <brenin.rhodes@smilecdr.com>
TahaAttari
commented
Mar 1, 2024
Comment on lines
+92
to
+93
| @SuppressWarnings("unchecked") | ||
| default <T extends ICompositeType & IBaseHasExtensions> List<T> getOwnedRelatedArtifacts() { |
There was a problem hiding this comment.
not sure why this is causing the Warning
TahaAttari
commented
Mar 18, 2024
| var resources = resourceMap.computeIfAbsent(resource.fhirType(), r -> new HashMap<>()); | ||
| var theId = resource.getIdElement().toUnqualifiedVersionless(); | ||
| var outcome = new MethodOutcome(theId, false); |
There was a problem hiding this comment.
outcome should have the ID of the newly updated resource
added 3 commits
March 18, 2024 14:30
barhodes
reviewed
Mar 19, 2024
cqf-fhir-utility/src/main/java/org/opencds/cqf/fhir/utility/PackageHelper.java
Outdated
Show resolved
Hide resolved
barhodes
reviewed
Mar 19, 2024
cqf-fhir-utility/src/main/java/org/opencds/cqf/fhir/utility/PackageHelper.java
Outdated
Show resolved
Hide resolved
barhodes
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.