Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurescorer bug fix #410

Merged
merged 13 commits into from
Feb 1, 2024
Merged

Measurescorer bug fix #410

merged 13 commits into from
Feb 1, 2024

Conversation

Capt-Mac
Copy link
Contributor

closes #400

adding extensions to each group and/or stratum that calculates measureScore by accumulating values that match designed set logic for respective populations in a measureReport resource.

https://build.fhir.org/ig/HL7/cqf-measures/measure-conformance.html#proportion-measure-scoring

Any existing logic that aggregates or scores based off of only numerator/denominator will need to be updated in order to calculate the measure-score accurately, especially where denominator exception cases are used.

Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these .DS_Store files should not be added to the repo.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c23ac23) 43.59% compared to head (50d356c) 43.89%.

Files Patch % Lines
...cqf/fhir/cr/measure/r4/R4MeasureReportBuilder.java 83.67% 1 Missing and 7 partials ⚠️
.../fhir/cr/measure/dstu3/Dstu3MeasureDefBuilder.java 84.61% 0 Missing and 2 partials ⚠️
...ds/cqf/fhir/cr/measure/r4/R4MeasureDefBuilder.java 84.61% 0 Missing and 2 partials ⚠️
...s/cqf/fhir/cr/measure/common/MeasureEvaluator.java 85.71% 0 Missing and 1 partial ⚠️
...ir/cr/measure/dstu3/Dstu3MeasureReportBuilder.java 0.00% 0 Missing and 1 partial ⚠️
.../cqf/fhir/cr/measure/r4/R4MeasureReportScorer.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #410      +/-   ##
============================================
+ Coverage     43.59%   43.89%   +0.29%     
- Complexity     1646     1663      +17     
============================================
  Files           224      224              
  Lines         11778    11846      +68     
  Branches       1648     1658      +10     
============================================
+ Hits           5135     5200      +65     
+ Misses         6032     6026       -6     
- Partials        611      620       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Capt-Mac Capt-Mac merged commit 98a96ca into master Feb 1, 2024
6 checks passed
@Capt-Mac Capt-Mac deleted the measurescorer-bug-fix branch February 1, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeasureScorer does not calculate population exclusions or exceptions correctly
3 participants