Fix non-unique request resource ids #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barhodes
added
bug
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
============================================
+ Coverage 53.92% 53.95% +0.02%
- Complexity 2163 2165 +2
============================================
Files 280 280
Lines 11923 11928 +5
Branches 1633 1634 +1
============================================
+ Hits 6430 6436 +6
Misses 4863 4863
+ Partials 630 629 -1 ☔ View full report in Codecov by Sentry. |
JPercival
approved these changes
Feb 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PlanDefinition has multiple actions that use the same AcitivtyDefinition the resulting id's would not be unique within the bundle returned from $apply.
This fix prefixes the id of the request resource with the id from the action, if present. This allows for multiple resources to be generated by the same ActivityDefinition from different actions while still having a unique id within the response bundle.