Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for IG Repository #435

Merged
merged 15 commits into from
Feb 28, 2024
Merged

Bug fixes for IG Repository #435

merged 15 commits into from
Feb 28, 2024

Conversation

JPercival
Copy link
Contributor

  • Update the Repository interface with some defaults for additional methods
  • Fixed context value being auto appended to path
  • Fixed support for external resources
  • Fixed support for mixed XML/JSON igs
  • Added support for conversion-on-write for IGs
  • Removed string-based overload on IGRepo in favor of Path

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 86.25592% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 53.91%. Comparing base (073a8c6) to head (ed2d945).

❗ Current head ed2d945 differs from pull request most recent head dae3ba6. Consider uploading reports for the commit dae3ba6 to get more accurate results

Files Patch % Lines
...s/cqf/fhir/utility/repository/ig/IgRepository.java 81.69% 21 Missing and 7 partials ⚠️
.../cqf/fhir/utility/repository/ig/IgConventions.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
+ Coverage     53.32%   53.91%   +0.58%     
- Complexity     2134     2162      +28     
============================================
  Files           281      280       -1     
  Lines         11843    11916      +73     
  Branches       1619     1632      +13     
============================================
+ Hits           6315     6424     +109     
+ Misses         4912     4863      -49     
- Partials        616      629      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival enabled auto-merge (squash) February 28, 2024 16:05
@JPercival JPercival merged commit e0c3d0d into master Feb 28, 2024
6 checks passed
@JPercival JPercival deleted the feature-kalm-bugfixes branch February 28, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants