Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor returns values for DataEntries that have no values #1156

Closed
mcmcphillips opened this issue Apr 19, 2023 · 3 comments
Closed

Processor returns values for DataEntries that have no values #1156

mcmcphillips opened this issue Apr 19, 2023 · 3 comments
Labels
bug md impact tracking The issue is impacting measure development

Comments

@mcmcphillips
Copy link

https://oncprojectracking.healthit.gov/support/browse/BONNIEMAT-1428

@brynrhodes

In Madie we are able to perceive issues with data entries being returned with no values. We can check this by

log.info( "FHIR CONTEXT IS {}", fhirContext .newJsonParser() .setPrettyPrint(true) .encodeResourceToString(r4EffectiveDataRequirements));

This displays multiple entries without values

}, { "profile": [ "http://hl7.org/fhir/ReferenceVersionRules" ], "mustSupport": [ "value" ] }, { "profile": [ "http://hl7.org/fhir/ReferredDocumentStatus" ], "mustSupport": [ "value" ] }, { "profile": [ "http://hl7.org/fhir/RelatedArtifactType" ], "mustSupport": [ "value" ] }, {

These additional values lead to multiple export lines with emp[ty values as displayed in BONNIEMAT-1428

@JSRankins
Copy link
Contributor

JSRankins commented Apr 19, 2023

@brynrhodes, I think the issue is that Data Requirements Processor seems to provide all data requirements back from included libraries, even if they were not used in the primary library. Not saying that is the wrong design. But we are using Data Requirements Processor to do the type conversion between QI-Core and FHIR. As part of that process, is there something in the src code to tease out the data requirements that are not directly or indirectly used by the primary library?

@brynrhodes brynrhodes added the bug label Apr 25, 2023
@jenseeman jenseeman added the md impact tracking The issue is impacting measure development label Apr 26, 2023
@brynrhodes
Copy link
Member

Yes, the dataRequirementsProcessor takes an optional parameter that indicates which expressions in the Library should be considered. In that case, only items that are referenced by the given expressions will be considered. For use in measures, this means the top-level expressions referenced by the measure should be given. I've added test cases for the CMS143 and CMS149 measure content in the linked bonnie ticket to confirm effective data requirements calculation.

JPercival pushed a commit that referenced this issue Jul 11, 2023
* #1156: Added test cases for CMS143 and CMS149 to validate data requirements output

* #1147: Fixed invalid let ref during data requirements inference

* #1146: Added test for MedicationRequest to ensure expected ELM output

* #1109: Fixed newlines being stripped incorrectly in mixed single- and multi-line comments
brynrhodes added a commit that referenced this issue Jul 14, 2023
* #1156: Added test cases for CMS143 and CMS149 to validate data requirements output

* #1147: Fixed invalid let ref during data requirements inference

* #1146: Added test for MedicationRequest to ensure expected ELM output

* #1109: Fixed newlines being stripped incorrectly in mixed single- and multi-line comments
@brynrhodes
Copy link
Member

Included in 2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug md impact tracking The issue is impacting measure development
Projects
None yet
Development

No branches or pull requests

4 participants