-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELM Annotations Data Duplication #86
Comments
I've tried to upload the relevant files but keep running into errors. Please email me if you want them. |
I've noticed this as well as part of working on getting Annotations to serialize correctly to JSON, so I'm working on this, should have a fix soon. |
Hi Bryn, |
Apologies for the delay here, I got distracted, trying to get back to this. I've pushed a branch (fix-annotations) that has debugging statements that I've been using to track down the issue, you're welcome to take a look, the more eyes on it the better. It's clear what's happening, the narrative tracking that "paints" the text to use in the span isn't properly accounting for cases when the parse tree jumps forward and then back (as in a binary infix operator). That's as far as I got before I got distracted, I'll get back to it as soon as I can, but posting the branch so you can take a look too if you want. |
… as duplicate outputs by removing span links to local ids. Will log as a new issue and wait for feedback that these are required before pursuing any further.
This issue was corrected by pull request #94 and the fix will be included in the next release. |
I'm on the MITRE Bonnie team. I'm currently trying to create an html representation of the CQL that will have the appropriate data to enable logic highlighting.
My current attempts to derive cql from the XML ELM's annotations run into issues with duplicated information.
Does a strategy currently exist for re-creating CQL from the XML annotations and ignoring the duplication? If not, is this something that can be resolved during CQL-to-ELM generation?
Examples from CMS177:
Element references duplicated in full.
This snippet from the MDD Diagnosis annotation fully reproduces the contents of the MDD Encounter element. See references 58 and 48 below.
In addition, reference 48 contains the following:
"MDD Encounter" Encounter such that Diagnosis.prevalencePeriod overlaps Encounter.relevantPerioddefine "MDD Encounter":
See bolded portion. This line seems incorrectly formatted, with the define statement being appended where it shouldn't be.
So you have AgeInYearsAt(start of "Measurement Period") which is then duplicated. This is also seen with less, lessorequal, equal, greaterorequal and equal type elements.
Here we see the “during Encounter.relevantPeriod” clause duplicated in two different ways.
Thank you for your help.
The text was updated successfully, but these errors were encountered: