Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups/modernizations #1354

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Minor cleanups/modernizations #1354

merged 3 commits into from
Apr 19, 2024

Conversation

JPercival
Copy link
Contributor

  • Made locators a final element of CqlException, fixed cases where it was missing
    • Removed logic handling that case
  • Removed some code along impossible code paths
  • Swapped to var in a few places
  • Cleaned up some straggling javax imports.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (fe5c101) to head (dde590a).

Files Patch % Lines
.../preprocessor/CqlPreprocessorElmCommonVisitor.java 84.84% 2 Missing and 3 partials ⚠️
.../cqframework/cql/cql2elm/CqlCompilerException.java 57.14% 3 Missing ⚠️
...va/org/cqframework/cql/cql2elm/LibraryBuilder.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1354      +/-   ##
============================================
+ Coverage     63.14%   63.18%   +0.03%     
  Complexity     6127     6127              
============================================
  Files           468      468              
  Lines         25358    25336      -22     
  Branches       4719     4716       -3     
============================================
- Hits          16013    16008       -5     
+ Misses         7184     7171      -13     
+ Partials       2161     2157       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 67bb03a into master Apr 19, 2024
5 checks passed
@JPercival JPercival deleted the chore-cleanup branch April 19, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants