Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to TypeScript? #236

Closed
dwwinters opened this issue Mar 22, 2021 · 4 comments · Fixed by #260
Closed

Port to TypeScript? #236

dwwinters opened this issue Mar 22, 2021 · 4 comments · Fixed by #260
Labels
enhancement New feature or request question Further information is requested

Comments

@dwwinters
Copy link

I was really happy to see #47 get closed out. Is there anyone out there looking to port this library to TypeScript?

@dwwinters dwwinters added enhancement New feature or request question Further information is requested labels Mar 22, 2021
@cmoesel
Copy link
Member

cmoesel commented Mar 22, 2021

We're taking it one step at a time. I really like TypeScript, but there are real gaps and limitations (in regard to implementation of the spec) that I think we need to invest in first before investing in porting this to TypeScript. Unless someone else steps in and does it, I expect we won't see a TypeScript implementation for a little while.

Are you asking this from the point of view of someone wanting to work on the library itself, or someone wanting to consume the library? If the latter, it's likely feasible that we could publish some .d.ts files that provide type definitions for the few outward-facing API points in the library (the executor, patient source, code service, etc).

@hossenlopp
Copy link
Contributor

We defined a few TypeScript definitions for the cql-execution outward API for our fqm-execution library. These could possibly be used as a starting point for the inclusion of types in the library.

https://github.com/projecttacoma/fqm-execution/blob/master/src/types/CQLExecution.d.ts
https://github.com/projecttacoma/fqm-execution/blob/master/src/types/CQLTypes.ts

@dwwinters
Copy link
Author

@cmoesel it's really more of the latter for me. Thanks @hossenlopp ! That should be a big help if I end up needing the types for a project I'm working on.

@mgramigna
Copy link
Contributor

@dwwinters Just to chime in with an update here, our team is planning on porting cql-execution to TypeScript, along with some other features, for a v3.0 release. No specific timeline here, and the changes may be incremental (we're going to start by just using any for things and setup the proper TS infrastructure before moving on to stricter typing).

But it's coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants