Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cql-execution port to ES6... #47

Closed
brynrhodes opened this issue Sep 12, 2018 · 17 comments
Closed

cql-execution port to ES6... #47

brynrhodes opened this issue Sep 12, 2018 · 17 comments
Labels
enhancement New feature or request

Comments

@brynrhodes
Copy link
Member

From @turp1twin on November 17, 2016 4:47

I have nothing against Coffeescript, but its future as a language has been debated as of late (due to ES6, ES7, babel, etc)... I have ported the cql-execution engine (and all tests) to ES6, which even with decaffeinate was more work than one might think! Not sure if you are interested, but I am willing to contribute it if you want it.. If not, no big deal, just thought I would offer it up... I currently have it in a private repo, but will open it up if there is any interest. Cheers!

Jeff

Copied from original issue: cqframework/clinical_quality_language#80

@brynrhodes
Copy link
Member Author

From @cmoesel on December 8, 2016 2:7

Hi Jeff,

I think this sounds awesome. After taking a long break from anything Javascript related, I've recently come back and found that I really like ES6 -- and some of the great tooling that's been built around ES6. If I was writing cql-execution today, I'd certainly write it in ES6!

That said, we have a team that's already invested in the Coffeescript version (and is using Coffeescript elsewhere in their app). They are a bit reluctant, at this point, to take on the risk of a full translation into ES6. That may change, but that seems to be where things stand now.

But... I'd personally love to see your ES6 implementation. Any chance you could grant me access so I could poke around and see how it works?

@brynrhodes brynrhodes added the enhancement New feature or request label Sep 12, 2018
@brynrhodes
Copy link
Member Author

From @turp1twin on December 8, 2016 21:38

Hey Chris,

Yeah, sounds good. I will give you access. It is still a work in progress, and there are a few bits that I still need to work out. That being said, I tried to stay as close to the structure you have in the coffee project, but might start to reorganize things a bit more... Anyways, have a play...

Jeff

@brynrhodes
Copy link
Member Author

From @seanknox on December 14, 2016 6:5

Hey @turp1twin, the Able Health team would love to participate if possible. Shoot me an email if you're interested: knoxville@ablehealth.com.

@brynrhodes
Copy link
Member Author

From @turp1twin on December 14, 2016 15:51

Hey @seanknox, glad to get you involved. Will send you an email with some details...

Jeff

@brynrhodes
Copy link
Member Author

From @preston on February 8, 2017 16:51

+1 to either ES6 or TypeScript-based canonical version. CoffeeScript was great while it lasted, but just isn't needed anymore.

@brynrhodes
Copy link
Member Author

From @preston on February 8, 2017 16:52

@turp1twin Hi Jeff: any chance you may be able to make your version of the project available soon?

@brynrhodes
Copy link
Member Author

From @turp1twin on February 8, 2017 17:2

Hey @preston I'll open it up later today. That being said, it needs some love, looking forward to contributions....

@brynrhodes
Copy link
Member Author

From @preston on February 8, 2017 17:15

@turp1twin Right on... do you think it's in a functional enough state to be suitable for npm packaging/release as well?

For context, I'm a contributor to the CQF Knartwork project, and would love to be able to integrate these libraries either directly or through a web service interface.

@brynrhodes
Copy link
Member Author

From @turp1twin on February 8, 2017 17:19

@preston The unit tests all run, but that is about all I have done with it so far. My day job has been keeping me crazy busy. The readme definitely needs updating for sure, before doing an NPM release....

@brynrhodes
Copy link
Member Author

From @turp1twin on February 8, 2017 17:22

@preston The repository is public now...

@brynrhodes
Copy link
Member Author

From @rdingwell on February 8, 2017 19:53

@preston as long as the port didn't change any of the api name spacing or method signatures you should be able to get started with the cql-execution npm package that is already published and built from the coffeescript version of the library.

https://www.npmjs.com/package/cql-execution

@psbrandt
Copy link

psbrandt commented Oct 4, 2018

Is this ticket being actively worked on? Has decaffeinate been considered?

@cmoesel
Copy link
Member

cmoesel commented Oct 4, 2018

Hi @psbrandt. I did some work on this about 6 months ago (see the decaffeinate branch -- but it was interrupted midway through by a flurry of changes to the master (coffeescript) branch by a team that needed to implement enhancements/fixes ASAP. A lot of really good changes were made there, and continued to be made as the CQL 1.3 specification evolved to its final state.

So... Now master has diverged quite a bit from the initial ES6 port and I'll likely end up starting the port from scratch, because, honestly, that will probably be easier than trying to decaffeinate and merge into the formerly decaffeinated branch. I was just waiting for activity on master to settle down and stabilize a bit before picking it up again. I think we're close!

@psbrandt
Copy link

psbrandt commented Oct 4, 2018

Ah, sorry, I didn't see the branch. Plan sounds good 👍

@cmoesel
Copy link
Member

cmoesel commented Oct 4, 2018

NP. Thanks for asking, and thanks for confirming that it's a feature wanted by others as well.

@awatson1978
Copy link

+1 for the need for an ES6 port. This needs to be prioritized if CQL is to be adopted by the broader Node/React community. Can we get this back on the radar and prioritized?

@cmoesel
Copy link
Member

cmoesel commented Jan 4, 2021

Hi @awatson1978 and @psbrandt -- CQL Execution 2.0.0 was released at the end of last year and is a true JavaScript port. Hopefully you already saw that, but if not, sorry for the late notice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants