raise exception when if_not_exists is not capable. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raise exception when calling if_not_exists for table with counter columns. refer to cqlengine#302 for details.
| @@ -170,3 +189,14 @@ def test_if_not_exists_is_not_include_with_query_on_update(self): | |||
| self.assertNotIn("IF NOT EXIST", query) | |||
|
|
|||
|
|
|||
| class IfNotExistWithCounterTest(BaseIfNotExistsWithCounterTest): | |||
|
|
|||
| def test_instance_raise_exception(self): | |||
There was a problem hiding this comment.
could you change this to use the context manager instead? There's a few examples in cqlengine/tests/test_timestamp.py
There was a problem hiding this comment.
sure, I just realize that cqlengine didn't support python 2.6.
rustyrazorblade
added a commit
that referenced
this pull request
Jan 23, 2015
raise exception when if_not_exists is not capable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise exception when calling if_not_exists for table with counter
columns. refer to cqlengine#302 for details.