[ML] Fix Limit Dropdown, simplify state management of Anomaly Explore…

…r. (elastic#23388) - This fixes the limit dropdown behavior. The fix for that is actually just the $scope.appState.fetch(); statements in explorer_controller.js, they avoid to run the information stored in appState across modules out of sync. - Additionally, the aim of this PR is to simplify the state management of Anomaly Explorer in the context of selecting cells in the swimlanes and updating the influencers list, charts and table accordingly.
cqliu1 · Sep 25, 2018 · a25fc75 · a25fc75
1 parent 775ae1b
commit a25fc75
Show file tree

Hide file tree

Showing 9 changed files with 358 additions and 350 deletions.
diff --git a/x-pack/plugins/ml/public/explorer/explorer.html b/x-pack/plugins/ml/public/explorer/explorer.html
@@ -55,14 +55,7 @@
           ng-mouseenter="setSwimlaneSelectActive(true)"
           ng-mouseleave="setSwimlaneSelectActive(false)"
         >
-          <ml-explorer-swimlane
-            swimlane-type="overall"
-            swimlane-data="overallSwimlaneData"
-            selected-job-ids="selectedJobIds"
-            chart-width="swimlaneWidth"
-            app-state="appState"
-            style="width: 100%; height: 250px;">
-          </ml-explorer-swimlane>
+          <ml-explorer-swimlane swimlane-type="overall" />
         </div>
 
         <div ng-if="viewBySwimlaneOptions.length > 0">
@@ -95,14 +88,7 @@
             ng-mouseenter="setSwimlaneSelectActive(true)"
             ng-mouseleave="setSwimlaneSelectActive(false)"
           >
-            <ml-explorer-swimlane
-              swimlane-type="viewBy"
-              swimlane-data="viewBySwimlaneData"
-              selected-job-ids="selectedJobIds"
-              chart-width="swimlaneWidth"
-              app-state="appState"
-              style="width: 100%; height: 250px;">
-            </ml-explorer-swimlane>
+            <ml-explorer-swimlane swimlane-type="viewBy" />
           </div>
 
           <div ng-if="!showViewBySwimlane()" class="text-center visualize-error euiText">

diff --git a/x-pack/plugins/ml/public/explorer/explorer_charts/explorer_charts_container_directive.js b/x-pack/plugins/ml/public/explorer/explorer_charts/explorer_charts_container_directive.js
@@ -65,6 +65,8 @@ module.directive('mlExplorerChartsContainer', function (
         element[0]
       );
     }
+
+    mlExplorerDashboardService.chartsInitDone.changed();
   }
 
   return {

diff --git a/x-pack/plugins/ml/public/explorer/explorer_constants.js b/x-pack/plugins/ml/public/explorer/explorer_constants.js
@@ -13,3 +13,10 @@ export const DRAG_SELECT_ACTION = {
   ELEMENT_SELECT: 'elementSelect',
   DRAG_START: 'dragStart'
 };
+
+export const SWIMLANE_DEFAULT_LIMIT = 10;
+
+export const SWIMLANE_TYPE = {
+  OVERALL: 'overall',
+  VIEW_BY: 'viewBy'
+};