Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS-34671 Enhanced the AST traversal performance #49

Merged
merged 3 commits into from
Jun 19, 2023
Merged

TS-34671 Enhanced the AST traversal performance #49

merged 3 commits into from
Jun 19, 2023

Conversation

stahlbauer
Copy link
Collaborator

Addresses issue TS-34671

  • No findings in Teamscale (c.f. vote of the Teamscale Bot). Flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.
  • Changes are tested adequately
  • CHANGELOG.md of the affected packages are updated

DreierF
DreierF requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@DreierF DreierF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you please add a CHANGELOG entry?
Did you test the performance as well?

packages/teamscale-javascript-instrumenter/src/instrumenter/Postprocessor.ts Outdated Show resolved Hide resolved
@stahlbauer
Copy link
Collaborator Author

Changelog adjusted and performance evaluated. Tests improved from 550 ms to 350 ms. Instrumenting a 2 MB js file improved by 10 percent points.

@DreierF DreierF merged commit 19d1ae6 into master Jun 19, 2023
1 of 2 checks passed
@DreierF DreierF deleted the ts/34671_visit_performance_opt branch June 19, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DreierF DreierF DreierF requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stahlbauer @DreierF