Fix performance regression on processors that allow unaligned mem access. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 18, 2017
The entirety of the rest of the file uses 8-width tabs, but this[1] change added 4-width spaces. 1. db45d67 ("Fix performance regression on processors that allow unaligned memory access. (cr-marcstevens#30)", 2017-05-18)
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 18, 2017
This is the feedback I left on pull request cr-marcstevens#30[1] turned into a patch. 1. cr-marcstevens#30
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 18, 2017
The entirety of the rest of the file uses 8-width tabs, but this[1] change added 4-width spaces. 1. db45d67 ("Fix performance regression on processors that allow unaligned memory access. (cr-marcstevens#30)", 2017-05-18)
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 18, 2017
This is the feedback I left on pull request cr-marcstevens#30[1] turned into a patch. 1. cr-marcstevens#30
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 19, 2017
The entirety of the rest of the file uses 8-width tabs, but this[1] change added 4-width spaces. 1. db45d67 ("Fix performance regression on processors that allow unaligned memory access. (cr-marcstevens#30)", 2017-05-18)
avar
added a commit
to avar/sha1collisiondetection
that referenced
this pull request
May 19, 2017
This is the feedback I left on pull request cr-marcstevens#30[1] turned into a patch. 1. cr-marcstevens#30
edef1c
pushed a commit
to edef1c/grit
that referenced
this pull request
Feb 13, 2019
This is the feedback I left on pull request #30[1] turned into a patch. 1. cr-marcstevens/sha1collisiondetection#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix detects architectures that support unaligned memory access and avoids a memory copy on such platforms. This holds on the x86-32 and -64 processors, which are a common use case.
See discussion: 33a694a