Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup preprocessing #14

Merged
merged 10 commits into from Nov 9, 2021
Merged

Cleanup preprocessing #14

merged 10 commits into from Nov 9, 2021

Conversation

reubenlindroos
Copy link
Collaborator

  • grammar
  • confusing "file not found" warnings

cr333
cr333 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Owner

@cr333 cr333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few tiny tweaks.

Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/op_preprocessor.py Outdated Show resolved Hide resolved
Python/preprocessing/traj_preprocessor.py Outdated Show resolved Hide resolved
reubenlindroos and others added 6 commits November 9, 2021 09:59
@reubenlindroos @cr333
Update Python/preprocessing/op_preprocessor.py
e383409 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos @cr333
Update Python/preprocessing/op_preprocessor.py
76c61f7 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos @cr333
Update Python/preprocessing/op_preprocessor.py
0d7ae82 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos @cr333
Update Python/preprocessing/op_preprocessor.py
c52e1c6 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos @cr333
Update Python/preprocessing/traj_preprocessor.py
e08eead 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos @cr333
Update Python/preprocessing/op_preprocessor.py
46b7264 
Co-authored-by: Christian Richardt <christian@richardt.name>
@reubenlindroos reubenlindroos merged commit 8f4b0cd into main Nov 9, 2021
@reubenlindroos reubenlindroos deleted the preproc-cleanup branch November 9, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cr333 cr333 cr333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenlindroos @cr333