Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent node from crashing on invalid UTM zone #682

Conversation

MCFurry
Copy link

@MCFurry MCFurry commented Jul 16, 2021

GeographicLib throws an error when a gps message is received and the current set UTM frame is invalid (i.e. too far away).
This is a valid error of course, but it also makes the node crash.
Now the error is catched and the user is warned about this.

@ayrton04
Copy link
Collaborator

LGTM, thank you!

@ayrton04 ayrton04 merged commit 9980cf3 into cra-ros-pkg:noetic-devel Jul 20, 2021
@MCFurry
Copy link
Author

MCFurry commented Jul 20, 2021

Thanks for merging. I might create a similar try-catch-fix for ROS2, but I'm not sure which branch to use there?
It seems that the conversion to geographiclib is done here: #643
but didn't end up in the ROS2 branch at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants