Fix/set utm map frame change #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. And yes, please PR to ROS 2. |
|
Thanks, I'll make a ROS2 PR as well! |
|
On that note, it seems that foxy-devel already switched to using geographiclib for UTM conversions: #643 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out that the
/setUTMZoneservice works in fixing navsat_transform into a certain UTM zone. However, the published transform is not updated, which means that alignment errors can occur.This PR fixes that issue.
If desired I can create a similar PR to the ROS2 branch, but let's confirm first this is a desired fix as is.