Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for navsat_transform launch param #533

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Minor fix for navsat_transform launch param #533

merged 1 commit into from
Feb 5, 2020

Conversation

mabelzhang
Copy link
Contributor

(I swear I didn't break this one with my PRs. File was last modified 2 months ago.)

Minor fix to appease rclcpp parameter complaining about a double being an int.

Without the fix, navsat_transform.launch.py cannot be launched:

$ ros2 launch robot_localization navsat_transform.launch.py 
...
[navsat_transform_node-1] terminate called after throwing an instance of 'rclcpp::ParameterTypeException'
[navsat_transform_node-1]   what():  expected [double] got [integer]
[ERROR] [navsat_transform_node-1]: process has died [pid 8783, exit code -6, cmd '/home/developer/tri_open_source/colcon_ws_debug/install/robot_localization/lib/robot_localization/navsat_transform_node __node:=navsat_transform_node __params:=/home/developer/tri_open_source/colcon_ws_debug/install/robot_localization/share/robot_localization/params/navsat_transform.yaml'].

On a related note, a ROS 2 ticket exists to make integer acceptable when double is expected integer to double ros2/rclcpp#979

@SteveMacenski SteveMacenski merged commit 0b5f691 into cra-ros-pkg:dashing-devel Feb 5, 2020
@mabelzhang mabelzhang deleted the dashing-fix-navsat-param branch February 12, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants