refactor: seperate crabml-vulkan and crabml-wgpu #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why separate these as standalone crates instead of putting them inside backends?
Different backends (like vulkan, wgpu, cuda, etc) are expected to have different dependencies, and these dependencies are always quite large, and sometimes have conflicts at runtime (likewise, if we had already initialized wgpu device, vulkano will hang on loading the libraries, at least on my laptop).
We have to carefully manage these dependencies via feature flags if we still keep them inside the same crate.
After separating them into different crates, it makes dependency management much easier. Additionally, we can abstract all of them under the same interface.