-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to run without HTTPS #5
Comments
there was a point chrome and ff would block mic/cam access on http even on localhost... so debugging was not really possible without this solution. I will check and remove https if this has changed. |
From https://blog.mozilla.org/webrtc/camera-microphone-require-https-in-firefox-68/: "Some good news for web developers is that camera and microphone will continue to work from http://localhost! This is thanks to the modern definition of secure context, which defines local sources as secure." So, HTTPS does not seem to be needed. Hopefully Firefox works as that blog says and chrome/chromium does the same. |
checked it and seems to work on chrome and ff with http on localhost. But if we remove this you always need a reverse proxy to host it, don't know if people like this if they just want to spinup a test server? |
IMO it is easier to install apache2+certbot and have a correct Let's encrypt certificate than getting let's encrypt certificate into node app or dealing with self-signed certificates, even for a test server. Maybe add some links and example configuration for apache/nginx + certbot to README instead? |
Ok, removed it and put it on the dev branch for now, maybe it has some side effects u never know :) |
Yes, going to try it and post apache config when I get it working with my setup. |
you'll need to change the https to http in the config file if you already have one |
Here is how my config looks like:
|
thanks added the part the the readme and also fixed the "user exits the room" bug. |
Hai @cracker0dks this is awesome project. thanks for initiate. |
When running behind reverse proxy, there is no need to have HTTPS.
Also, maybe just remove this feature completely for simplicity, so TLS is always handled by the web server? What is the current best practice for node applications?
The text was updated successfully, but these errors were encountered: