-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding PDF as images #45
Comments
mmm we would probably need to add the pdf.js lib. Is this really a feature that would be used often so it's worth to implement? |
Thanks for your consideration. PDFs are ubiquitous and image formats much less common in academic contexts. Converting to PNG is an option, but cumbersome and several clicks away, so I’d end up grabbing a screenshot of the page, producing an unnecessarily large PNG that eats up resources. |
(By the way, server-side imagemagick might also be an option, though no idea which one would be simpler.) |
Collaboration with pdf is needed, now we will convert everything into images and place it on canvas. If it’s possible to paint on top of pdf, it will be great. Regards, Ivan Semencha |
added this function with the last commit. I used pdfjs because you don't need install imagemagick on the serverside and the upload is a lot smaller with one image compaired to the hole pdf. |
@cracker0dks works as promised, and then some. Thank you! |
Would you consider supporting PDF embeds, dragged-and-dropped into the whiteboard just like images? Only the first page of the PDF would be rendered, of course. Several commercial whiteboards offer this feature already, and I think it makes sense especially in an educational context.
Thank you for this fantastic piece of work.
The text was updated successfully, but these errors were encountered: