cracklib-update missing from tarball.

[ht990332]

Hello. This might be my bad eyesight :) but I believe cracklib-update script is missing from the release tarball but is actually called from the Makefile.

https://github.com/cracklib/cracklib/releases/download/v2.9.9/cracklib-2.9.9.tar.bz2

[p-linnane]

Also seen in Homebrew/homebrew-core#124807

[atsampson]

The man pages in the doc directory are also missing from the tarball.

It would be a good idea to test that building from the tarball works as part of the release process.

[srcshelton]

#53 doesn't actually fix this issue - with that patch applied:

Making all in util
make[2]: Entering directory '/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9-abi_x86_64.amd64/util'
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util -I..  -I. -I.. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/lib '-DDEFAULT_CRACKLIB_DICT="/usr/lib/cracklib_dict"' '-DLOCALEDIR="/usr/share/locale"' -Wall   -O2 -march=skylake -mabm -pipe -c -o packer.o /var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util/packer.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util -I..  -I. -I.. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/lib '-DDEFAULT_CRACKLIB_DICT="/usr/lib/cracklib_dict"' '-DLOCALEDIR="/usr/share/locale"' -Wall   -O2 -march=skylake -mabm -pipe -c -o unpacker.o /var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util/unpacker.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util -I..  -I. -I.. -I/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/lib '-DDEFAULT_CRACKLIB_DICT="/usr/lib/cracklib_dict"' '-DLOCALEDIR="/usr/share/locale"' -Wall   -O2 -march=skylake -mabm -pipe -c -o check.o /var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9/util/check.c
make[2]: *** No rule to make target 'cracklib-update', needed by 'all-am'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9-abi_x86_64.amd64/util'
make[1]: *** [Makefile:442: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/sys-libs/cracklib-2.9.9/work/cracklib-2.9.9-abi_x86_64.amd64'
make: *** [Makefile:372: all] Error 2

[TimB87]

@nneul I have the same problem packaging the update for CRUX.

[nneul]

Thank you.

[p-linnane]

The patch that was merged does not result in a successful build for cracklib. I am seeing the same errors as @srcshelton posted above.

[nneul]

I'm actually not seeing any issues building with current head of main? Can you elaborate?

[heirecka]

Well, applying the patch will only fix generating a new tarball, it'll do nothing for 2.9.9 when applied to that.

[nneul]

If I can get a few people to sign off on tarballs built from current head, I'll get 2.9.10 packaged and uploaded.

[heirecka]

Just built a tarball generated with make dist sucessfully.

[p-linnane]

Confirming that I was able to build HEAD with Hombrew.