Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty Field Update #38

Closed
JosephFidelino opened this issue Apr 6, 2018 · 4 comments
Closed

Empty Field Update #38

JosephFidelino opened this issue Apr 6, 2018 · 4 comments
Assignees
@aprilsacil
Labels
Status: Deployed If the code was reviewed and released. Type: Bug For any errors found

Comments

@JosephFidelino
Copy link

System should update the optional fields even if the value is empty. Expected result upon submission is that optional field should be empty.
@cjestavillo
Copy link
Contributor

This is now working as expected.
Reference commit: CradlePHP/cradle-system@14afc7f

@cjestavillo cjestavillo added Status: Deployed If the code was reviewed and released. Type: Bug For any errors found Status: In Progress If someone or you are currently working on it and removed Status: Deployed If the code was reviewed and released. labels Apr 6, 2018
@cjestavillo cjestavillo added Status: Deployed If the code was reviewed and released. and removed Status: In Progress If someone or you are currently working on it labels Apr 17, 2018
@cjestavillo
Copy link
Contributor

Code had been reverted back.. and it had been decided that the null values will be handled depending on the schema.
Reference commit: CradlePHP/cradle-system@064fa05

@JosephFidelino JosephFidelino removed the Status: Deployed If the code was reviewed and released. label Apr 18, 2018
@cblanquera
Copy link

@cjestavillo can I get a confirmation this is now working?

@hmenorjr hmenorjr self-assigned this May 22, 2018
@hmenorjr
Copy link
Contributor

@cblanquera This isn't working yet. I confirmed by creating a new cradle on my local.

@aprilsacil aprilsacil self-assigned this Jun 7, 2018
@aprilsacil aprilsacil added Status: Complete If the task is ready for review. Status: Deployed If the code was reviewed and released. and removed Status: Complete If the task is ready for review. labels Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aprilsacil aprilsacil

Labels
Status: Deployed If the code was reviewed and released. Type: Bug For any errors found
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cblanquera @aprilsacil @hmenorjr @JosephFidelino @cjestavillo