Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_piano_roll does not take the MIDI sustain CC into account #130

Closed
craffel opened this issue May 11, 2017 · 0 comments
Closed

get_piano_roll does not take the MIDI sustain CC into account #130

craffel opened this issue May 11, 2017 · 0 comments

Comments

@craffel
Copy link
Owner

craffel commented May 11, 2017

MIDI CC 64 is the "sustain pedal" control channel. If it's on, notes should be held until it's turned off. get_piano_roll doesn't take this into account.
@maezawa-akira maezawa-akira mentioned this issue Apr 10, 2018
Closed
maezawa-akira added a commit to maezawa-akira/pretty-midi that referenced this issue Apr 10, 2018
@maezawa-akira
- Add pedal for chroma and piano roll (craffel#130)
e5e3747
@maezawa-akira maezawa-akira mentioned this issue Apr 10, 2018
Merged
maezawa-akira added a commit to maezawa-akira/pretty-midi that referenced this issue Apr 14, 2018
@maezawa-akira
revised craffel#130 - documented the code and replaced pedal logic wi…
de0d8db 
…th a simpler algorithm
maezawa-akira added a commit to maezawa-akira/pretty-midi that referenced this issue Apr 17, 2018
@maezawa-akira
Revise craffel#130 - unify use of pedals to single parameter pedal_th…
3ff2466 
…reshold
maezawa-akira added a commit to maezawa-akira/pretty-midi that referenced this issue Apr 17, 2018
@maezawa-akira
Fix unit-tests for craffel#130
639889d
craffel pushed a commit that referenced this issue Apr 24, 2018
@maezawa-akira @craffel
Add support for sustain pedal (pianoroll and chromagram) (#142)
e3ab5f9 
* Added support for elongating note when encountering CC64

*  - Add unit-tests

*  - Add pedal for chroma and piano roll (#130)

* revised #130 - documented the code and replaced pedal logic with a simpler algorithm

* Revise #130 - unify use of pedals to single parameter pedal_threshold

* Fix unit-tests for #130

* Fix pep8 formatting issues

* Set the default pedal value to 64

* Modified tests to match the current specifications

* Use >= pedal_threshold as a condition for detecting pedal-on
@craffel craffel closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craffel