Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py should install midi package from GitHub #92

Closed
craffel opened this issue Sep 16, 2016 · 3 comments
Closed

setup.py should install midi package from GitHub #92

craffel opened this issue Sep 16, 2016 · 3 comments

Comments

@craffel
Copy link
Owner

craffel commented Sep 16, 2016 •
edited
Loading

cc @cghawthorne

Some people have trouble with pip install midi, see #72 or vishnubob/python-midi#66. The midi package is also out-of-date (v0.2.3). The python-midi package on PyPI is more up-to-date, but doesn't appear to be maintained by the owner of midi: vishnubob/python-midi#72 And, despite being more up-to-date, as of writing it is over 2 years stale. There are features/changes added since then which are needed in pretty_midi. To deal with this, README suggests using the bleeding-edge from GitHub. We should specify this in setup.py too.
craffel added a commit that referenced this issue Sep 16, 2016
@craffel
Give GitHub link for midi package in setup.py
e8de922 
Due to issues with installing midi from pip (see #92), this should
explicitly make pip install the bleeding-edge.
@craffel craffel mentioned this issue Sep 16, 2016
Merged
craffel added a commit that referenced this issue Sep 16, 2016
@craffel
Give GitHub link for midi package in setup.py (#93)
aae8294 
Due to issues with installing midi from pip (see #92), this should
explicitly make pip install the bleeding-edge.
@craffel
Copy link
Owner Author

craffel commented Sep 16, 2016

Resolved in #93.

@craffel craffel closed this as completed Sep 16, 2016
@craffel
Copy link
Owner Author

craffel commented Sep 16, 2016

This is still causing problems.

@craffel craffel reopened this Sep 16, 2016
@craffel
Copy link
Owner Author

craffel commented Sep 16, 2016

Problems are not resolvable without fixing midi on PyPI.

@craffel craffel closed this as completed Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craffel