Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style definition for UL #112

Closed
AnsonSL opened this issue Jun 22, 2023 · 4 comments
Closed

Style definition for UL #112

AnsonSL opened this issue Jun 22, 2023 · 4 comments
Labels

Comments

@AnsonSL
Copy link

AnsonSL commented Jun 22, 2023

Description

Styles applied to lists and unordered lists using the styles plugin do not work. This appears to be a bug in CK Editor that may have been fixed: ckeditor/ckeditor5#14200

For example, I'm applying a larger font size to the paragraphs above and below a list. I'd like the list to also use a larger font size. I've setup a separate style for lists to apply a class that increases font size, but CK Editor removes the class.

Steps to reproduce

  1. Select a list
  2. Apply a style to the list

Additional info

  • Craft version: Craft CMS 4.4.11
  • PHP version: 8.1.10
  • Database driver & version: MYSQL 8.0.23
  • Plugins & versions: "3.4.0",
@AnsonSL AnsonSL added the bug label Jun 22, 2023
@i-just
Copy link
Contributor

i-just commented Jul 5, 2023

Hi, thanks for reaching out.

Yes, you are right; this behaviour (or lack thereof) comes from the CKEditor.

The issue you linked to from the CKEditor repository was fixed in v38.0.0; however, the fix only applies to DocumentLists and not Lists.

Craft’s CKEditor plugin uses Lists, and only one of those two can be used.

Only once To-do lists can work with DocumentLists (ckeditor/ckeditor5#11620), we can consider switching to the DocumentLists.

There’s also a chance this feature could be added by the CKEditor team to the Lists, as people are asking for it.

I hope the above helps!

@i-just i-just closed this as completed Jul 5, 2023
@ansonleclair
Copy link

Thanks for looking into this. Is there a possibility that we could choose which list the plugin used through config?

@i-just
Copy link
Contributor

i-just commented Jul 7, 2023

Not a problem. We’ll discuss this internally, but it looks like a solution will come from CKEditor; just not sure when: ckeditor/ckeditor5#14200 (comment).

@brandonkelly
Copy link
Member

CKEditor 3.5.0 is out with a new “List Plugin” setting 🎉 (#122)

Note that the update requires Craft 4.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants