Feature/112 list and documentlist switcher #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # src/Field.php # src/web/assets/ckeconfig/dist/ckeconfig.js.map # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js # src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map # src/web/assets/ckeditor/dist/ckeditor5-dll.js # src/web/assets/ckeditor/dist/translations/en-au.js # src/web/assets/ckeditor/dist/translations/fi.js # src/web/assets/ckeditor/dist/translations/gl.js # src/web/assets/ckeditor/dist/translations/hr.js # src/web/assets/ckeditor/dist/translations/pt-br.js # src/web/assets/ckeditor/dist/translations/sl.js # src/web/assets/ckeditor/dist/translations/sq.js # src/web/assets/ckeditor/dist/translations/ug.js # src/web/assets/ckeditor/dist/translations/uz.js # src/web/assets/ckeditor/dist/translations/zh.js
|
Updated the setting UI to a table that more clearly shows the differences: 
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When defining the CKEditor config, allow the user to choose between using
List+ListPropertiesorDocumentList+DocumentListProperties.In both cases, we use their
bulletedListandnumberedListbuttons, but theDocumentListsupports styling as described here: ckeditor/ckeditor5#14200.We include a switcher to allow users to choose because
ListandDocumentListcannot coexist, andDocumentListcan’t coexist withTodoList. So user’s options are:The saving of the todo list can only be tested in conjunction with PR#121.
This PR required updating CKEditor to at least version 38.0.0. That means the introduction of the “Powered by CKEditor” logo. This is what it looks like in the Control Panel (only shows when the field is in focus):
Related issues
#112