Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust .ck-content aria values (label, describedby) #166

Merged
merged 4 commits into from Feb 21, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Feb 13, 2024

Description

  • Modifies .ck-content aria-label to start with the field’s name.
  • Adds aria-describedby attribute to the .ck-content element.

After:
Screenshot 2024-02-13 at 12 56 41
Screenshot 2024-02-13 at 12 57 17

Related issues

#74

Copy link

@gcamacho079 gcamacho079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Tested on JAWS/Chrome and Microsoft Speech Recognition, and the experience is much improved! 👌🏼 🥳

i-just and others added 3 commits February 16, 2024 08:58
# Conflicts:
#	src/web/assets/ckeditor/dist/ckeditor5-craftcms.js
#	src/web/assets/ckeditor/dist/ckeditor5-craftcms.js.map
[ci skip]
@brandonkelly brandonkelly merged commit 15d11e8 into main Feb 21, 2024
@brandonkelly brandonkelly deleted the bugfix/74-accessibility-name-and-context branch February 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants