warn about callback fn when switching from js to json config #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When defining options for a CKEditor configuration in JavaScript, it’s possible to use callbacks. Callback functions don’t translate to JSON, so when you switch from JS to JSON, some of your config might get silently lost.
When switching from JS to JSON editor, check if the config contains any functions, and if it does, show a confirmation prompt before switching. If the user chooses to proceed, translate the JS config to JSON (and lose callbacks). If they cancel the switch, keep the config as it was.
Screen.Recording.2024-02-28.at.13.58.29.mov
Related issues
#152