Fixed exporting for < PHP 7.4

#9958 (comment)
craftcms · Oct 21, 2021 · 034e2d7 · 034e2d7
1 parent e45ce51
commit 034e2d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 
 ### Fixed
 - Fixed a PHP error that could occur when uploading assets on some environments.
+- Fixed a PHP error that occurred when exporting elements on PHP 7.2 or 7.3. ([#9958](https://github.com/craftcms/cms/issues/9958))
 - Fixed a JavaScript error that occurred in Safari. ([#9976](https://github.com/craftcms/cms/issues/9976))
 
 ## 3.7.17.1 - 2021-10-20

diff --git a/src/web/CsvResponseFormatter.php b/src/web/CsvResponseFormatter.php
@@ -85,6 +85,11 @@ public function format($response)
 
         $suspectCharacters = ['=', '-', '+', '@'];
 
+        $escapeChar = $this->escapeChar;
+        if ($escapeChar === '' && PHP_VERSION_ID < 70400) {
+            $escapeChar = '\\';
+        }
+
         foreach ($data as $row) {
             foreach ($row as &$field) {
                 if (is_scalar($field)) {
@@ -100,7 +105,7 @@ public function format($response)
                 }
             }
             unset($field);
-            fputcsv($fp, $row, $this->delimiter, $this->enclosure, $this->escapeChar);
+            fputcsv($fp, $row, $this->delimiter, $this->enclosure, $escapeChar);
         }
 
         fclose($fp);