Skip to content

Commit

Permalink
Make non-interactive overflow:auto panes keyboard-scrollable
Browse files Browse the repository at this point in the history
Resolves #7236
  • Loading branch information
brandonkelly committed Dec 12, 2020
1 parent 90fe154 commit af35fd9
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -10,6 +10,7 @@
- The Username, First Name, Last Name, Email, and New Password fields on Edit User pages now prevent LastPass from autofilling them. ([#7177](https://github.com/craftcms/cms/issues/7177))
- Field layout elements’ settings HUDs now automatically set the focus on the first text input when opened. ([#7175](https://github.com/craftcms/cms/issues/7175))
- Field instructions within the details pane are now replaced with info icons. ([#7180](https://github.com/craftcms/cms/issues/7180))
- Panes with `overflow: auto` and no focusable content within them now have `tabindex="0"` attributes, so their content can be keyboard-scrollable on Chromium and WebKit-based browsers. ([#7236](https://github.com/craftcms/cms/issues/7236))
- `users/set-password` requests now include a `status` key in JSON responses, set to the user’s status. ([#7239](https://github.com/craftcms/cms/issues/7239))

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions src/templates/_components/utilities/ProjectConfig.html
Expand Up @@ -11,7 +11,7 @@ <h2>{{ 'Apply YAML Changes'|t('app') }}</h2>
{% endif %}
{{ csrfInput() }}
{% if areChangesPending %}
<div id="diff" class="pane loading"></div>
<div id="diff" class="pane loading" tabindex="0"></div>
<div class="readable">
<blockquote class="note $noteClass">
<p>
Expand Down Expand Up @@ -139,7 +139,7 @@ <h2>{{ 'Rebuild the Config'|t('app') }}</h2>
<hr>

<h2>{{ 'Loaded Project Config Data'|t('app') }}</h2>
<div class="pane">
<div class="pane" tabindex="0">
<pre><code>{{ entireConfig }}</code></pre>
</div>
<div class="buttons">
Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/deprecationerrors/dist/deprecator.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/web/assets/deprecationerrors/src/deprecator.js
Expand Up @@ -29,7 +29,7 @@
viewLogTraces: function(ev) {
if (!this.tracesModal) {
var $container = $('<div id="traces" class="modal loading"/>').appendTo(Garnish.$bod);
this.$tracesModalBody = $('<div class="body"/>').appendTo($container);
this.$tracesModalBody = $('<div class="body" tabindex="0"/>').appendTo($container);

this.tracesModal = new Garnish.Modal($container, {
resizable: true
Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/updater/dist/Updater.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit af35fd9

Please sign in to comment.