Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 Field Layout editor slideouts should include a “Cancel” option #10587

Closed
mattstein opened this issue Feb 16, 2022 · 3 comments
Closed
Labels
accessibility 👤 features related to accessibility bug ux 😄 features related to user experience

Comments

@mattstein
Copy link
Contributor

Description

Field Layout editor slideouts can be dismissed via the esc key and by clicking outside the slideout, but for UX clarity and accessibility there should be an explicit option to cancel or dismiss changes so it’s not left to the user to guess.

Screen Shot 2022-02-16 at 11 30 47 AM@2x

Steps to reproduce

  1. Pick an entry type to edit. (SettingsSections → [any Edit entry type].)
  2. Click the gear icon next to any field in the Field Layout editor.
  3. Make some edits in the slideout you decide you don’t want to apply, then find the control that allows you to discard them.

Additional info

  • Craft version: 4.0.x-dev (decee14)
@mattstein mattstein added bug accessibility 👤 features related to accessibility ux 😄 features related to user experience labels Feb 16, 2022
@brandonkelly
Copy link
Member

Added a “Close” button to them for the next release.

(Un-applied changes are not actually lost when the field layout designer slideouts are closed, so “Cancel” wouldn’t have been appropriate as it implies the changes will be discarded.)

@mattstein
Copy link
Contributor Author

Makes sense, thank you!

@brandonkelly
Copy link
Member

Craft 4.0.0-beta.4 is out now with that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility bug ux 😄 features related to user experience
Projects
None yet
Development

No branches or pull requests

2 participants