Garnish menu btn still active even with disabled attribute in admin table

[BenParizek]

What happened?

Just a minor bug to note in the latest Commerce 4.0.0:

/admin/commerce/promotions/sales

Craft CMS version

4

Craft Commerce version

4

PHP version

8

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[nfourtythree]

Hi @BenParizek

Thank you for reporting, have just checked this with Commerce 3 and it is the same behaviour.

I don't think this is actually Commerce related specifically. But more likely a Garnish or Admin table issue.

Will transfer this to the cms repo so we can look at it in that context.

Thanks!

[brandonkelly]

@nfourtythree There aren’t any references to disabled in Garnish.CustomSelect or Garnish.DisclosureMenu, so this is probably a case of Commerce setting the disabled class on the button, which will give it the reduced-opacity styling we apply across the board via .disabled, though the component itself has no support for it. So probably more of a Commerce bug, or you can PR support for disabled to the component in use.