Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Image thumbnails within inactive tabs don't load when their tab is activated #12720

Closed
knufri opened this issue Feb 22, 2023 · 4 comments
Assignees

Comments

@knufri
Copy link

knufri commented Feb 22, 2023

What happened?

Description
Image thumbnails within inactive tabs don't load when their tab is activated.

Steps to reproduce
Created a Section with multiple tabs including an asset field in the second tab.
Upload an image to the asset field on the second tab.
Switch back to the first tab and reload the page.
Switch to the second tab, the image thumbnail won't be loaded.

Bildschirm­foto 2023-02-22 um 17 27 36

This bug was reported from me some time ago, see: #10918

It's a bit weird, sometimes the images load and sometimes they don't 🤔 sometimes they appear when you scroll or switch between the tabs. There are no js errors in the console.

Craft CMS version

4.3.10

PHP version

8.1

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Feb 23, 2023

Hi, thanks for reporting. I can only replicate it if I have a matrix field with collapsed blocks in an inactive tab. If I refresh the page, switch to the tab with the matrix field and expand the block that contains an image, the thumbnail doesn’t load.

I created a PR to fix this.

@knufri
Copy link
Author

knufri commented Feb 23, 2023

Hello @i-just, thank you for the very fast reply 👍 looking forward to the fix.

Best Regards
Jan

@brandonkelly
Copy link
Member

This is fixed for the next Craft 3 and 4 releases, via #12727!

@brandonkelly
Copy link
Member

Craft 3.7.68 and 4.3.11 are out with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants