Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x]: Global set reordering does not stick when using Safari #14752

Closed
amphibian opened this issue Apr 3, 2024 · 3 comments
Closed

[5.x]: Global set reordering does not stick when using Safari #14752

amphibian opened this issue Apr 3, 2024 · 3 comments
Assignees
@nfourtythree
Labels
bug

Comments

@amphibian
Copy link

What happened?

Description

When reordering global sets with Safari (17.4.1), a javascript error prevents the reorder from saving.

Steps to reproduce

  1. Create two or more global sets.
  2. Reorder those sets using Safari.
  3. Reload the page.

Expected behavior

The sets are in the new order.

Actual behavior

The sets are still in the old order.

Craft CMS version

5.0.0

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions
@amphibian amphibian added the bug label Apr 3, 2024
@linear Linear
Copy link

linear bot commented Apr 8, 2024

CMS-1291 [5.x] Global set reordering does not stick when using Safari

nfourtythree added a commit that referenced this issue Apr 9, 2024
@nfourtythree
Fixed #14752 admin table reordering not working in Safari
9e0d627
brandonkelly added a commit that referenced this issue Apr 9, 2024
@brandonkelly
Merge pull request #14777 from craftcms/feature/cms-1291-5x-global-se…
dd74864 
…t-reordering-does-not-stick-when-using-safari

Fixed #14752 admin table reordering not working in Safari
@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed for the next release.

@brandonkelly
Copy link
Member

Craft 4.8.8 and 5.0.3 are out with the fix for this. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfourtythree nfourtythree

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brandonkelly @amphibian @nfourtythree