Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Regression in display of disabled item in Vue AdminTable #14861

Closed
elivz opened this issue Apr 25, 2024 · 3 comments
Closed

[4.x]: Regression in display of disabled item in Vue AdminTable #14861

elivz opened this issue Apr 25, 2024 · 3 comments

Comments

@elivz
Copy link

elivz commented Apr 25, 2024

What happened?

Description

This commit switched from checking for the presence of a status attribute to checking for the coerced boolean value of that attribute. As a result, rows with status: false now display in bold without the empty/white status indicator. This issue is present throughout most of the tables in Commerce, which use that Vue component. It causes those disabled items to have a weird and confusing display. I haven't found any instances in Craft core where a status is set on a VueAdminTable.

Screenshot 2024-04-25 at 12 08 26 PM

Steps to reproduce

  1. Create a disabled discount, sale, or shipping method in Craft Commerce
  2. View the index page for that item type

Expected behavior

The disabled item should display with normal font weight and an empty circle next to the name, indicating that it is disabled.

Actual behavior

It is in bold font, with no indicator circle, and the left margin is misaligned.

Craft CMS version

4.8.10

PHP version

4.5.4

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@brandonkelly
Copy link
Member

Thanks for reporting that! Fixed for the next release.

@brandonkelly
Copy link
Member

Craft 4.8.11 and 5.0.6 are out with that fix. Thanks again!

@elivz
Copy link
Author

elivz commented May 1, 2024

Looks great now. Thanks Brandon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants