Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to add tabs into a block on the cp.html template #2128

Closed
andrelopez opened this issue Nov 23, 2017 · 3 comments
Closed

Support to add tabs into a block on the cp.html template #2128

andrelopez opened this issue Nov 23, 2017 · 3 comments
Labels
enhancement improvements to existing features need more info

Comments

@andrelopez
Copy link
Contributor

andrelopez commented Nov 23, 2017

Description

Any chance to add the ability of add tabs under a block like the content block? so we can override the default tabs code on the plugin's templates.

{# content-container #}
<div id="content-container">
    {% block tabs %}
        {% if tabs is defined and tabs %}
            {% include "_includes/tabs" %}
        {% endif %}
    {% endblock %}

    <div id="content">
        {% block content %}
            {{ content is defined ? content }}
        {% endblock %}
    </div>
</div>

Steps to reproduce

  1. file: template/_layouts/cp.html line 303

Additional info

  • Craft version: 3.0.0-RC1
  • PHP version: 7.0.0
@brandonkelly
Copy link
Member

brandonkelly commented Nov 23, 2017

Not sure I'm following – you’re saying you want tabs within tabs? What is the use case?

@brandonkelly brandonkelly added enhancement improvements to existing features need more info labels Nov 23, 2017
@andrelopez
Copy link
Contributor Author

Hi @brandonkelly

We need to override the code on "_includes/tabs" to add some custom data-attributes and ids to the <li> tags. Please let me know if you think there is a better way to update that code.

brandonkelly added a commit that referenced this issue Nov 28, 2017
@brandonkelly
Copy link
Member

Ah gotcha, yeah sure – done for RC1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features need more info
Projects
None yet
Development

No branches or pull requests

2 participants