Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the error text styling #2885

Closed
brandonkelly opened this issue May 15, 2018 · 2 comments

Comments

@brandonkelly
Copy link
Member

commented May 15, 2018

There is a form of color blindness where our red error text color is indistinguishable from normal text, making it impossible to spot the errors on a page.

@lukeyouell

This comment has been minimized.

Copy link

commented May 16, 2018

@brandonkelly on the topic of accessibility, having white text over the orange background in the error banner fails the colour contrast check:

image

brandonkelly added a commit to craftcms/sass that referenced this issue May 22, 2018
brandonkelly added a commit that referenced this issue May 22, 2018
fixes #2885
@brandonkelly

This comment has been minimized.

Copy link
Member Author

commented May 22, 2018

@lukeyouell Done :)

brandonkelly added a commit that referenced this issue May 22, 2018
resolves #2885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.