Eager loading asset transforms doesn't work (with potential fix)

[smcyr]

Description

I try to eager load asset transforms in a matrix and with or without the eager loading, the number of queries stay the same.

I checked in the code and in the method eagerLoadElements of Elements.php line 1694, the asset query is executed with asArray. In the method populate of AssetQuery.php, the withTransforms is skipped if asArray is true. So, if I comment asArray() in Elements.php, it's now working as intended.

Update: It seems the the culprit is this commit from 14 days ago:
ec292df#diff-a23f034d2592a363d6ae402cff459928

Steps to reproduce

1. Create a matrix field with an asset field inside
2. Loop in the matrix while eager loading the asset with withTransforms

Additional info

• Craft version: 3.3.2
• PHP version: 7.3.5
• Database driver & version: MySQL 5.5.5
• Plugins & versions:

[brandonkelly]

Thanks for reporting that! I’ve just fixed it for the next release.

To get the fix early, change your craftcms/cms requirement in composer.json to:

"require": {
  "craftcms/cms": "dev-develop#a6be2dc6349cdfd829a46b216f38d47a304ecca1 as 3.3.3",
  "...": "..."
}

Then run composer update.

[smcyr]

Wow, that was fast! Thanks, it's working!

[rmales]

I'm trying to debug some problems we're having with eager loading image transforms and came across this issue. It seems like the fix here was reverted at some point. Now it looks to me like because of this withTransforms doesn't work on nested fields, e.g. with code like:

{% set authors = entry.authors.with([
    ['profileImage', { withTransforms: ['avatarX1', 'avatarX2'] }],
]).all() %}

[gromgull]

Can confirm - it no longer works in 3.5.16 :(