Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revision menu button show unsupported site in drop down #5387

Closed
vnali opened this issue Dec 31, 2019 · 3 comments
Closed

revision menu button show unsupported site in drop down #5387

vnali opened this issue Dec 31, 2019 · 3 comments

Comments

@vnali
Copy link
Contributor

vnali commented Dec 31, 2019

Description
revision menu button show unsupported sites for some propagation methods

Steps to reproduce

  1. enable 3 sites:
  • en with en_US language
  • en2 with en_us langauge
  • fa with fa_IR language
  1. set propagation method to "Save entries to other sites with the same language"
  2. add new entry in en language
  3. go back to entry index page. select en language and go to edit page.
  4. en and en2 are in revision menu list which is correct but fa is also in list which is not correct. if you select fa language you get entry not found error.
    i kind of tracked the issue and it seems craft doesn't check unsupported Sites when create revision menu button in this line and loop in all sites .

Additional info

  • Craft version: 3.3.19
  • PHP version: 7.2
  • Plugins & versions: fresh install
@brandonkelly
Copy link
Member

Thanks for reporting that! Just fixed for the next release.

@benface
Copy link
Contributor

benface commented Jan 9, 2020

@brandonkelly Looks like there's a small typo in the fix: canEditMultilpeSites instead of canEditMultipleSites

@brandonkelly
Copy link
Member

Whoops, thanks for pointing that out. At least I was consistently wrong, so it didn’t break anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants