Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Redactor has 'clickToEdit' set to true, the wrong (non-Assets) file modal opens #7

Closed
angrybrad opened this issue Jan 28, 2017 · 2 comments
Closed

If Redactor has 'clickToEdit' set to true, the wrong (non-Assets) file modal opens #7

angrybrad opened this issue Jan 28, 2017 · 2 comments
Assignees
@brandonkelly
Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds wontfix

Comments

@angrybrad
Copy link
Member

Environment:

  • Craft version: 3.x
  • PHP version: 7.x
  • Database driver & version: N/A
  • Plugins & versions:

Description:

Craft's Assets file picker won't instantiate in the RTF if you have Redactor's clickToEdit enabled.

Steps to reproduce:

  1. Enable clickToEdit.

  2. Trigger the Asset file picker modal.
@angrybrad
Copy link
Member Author

angrybrad commented Jan 28, 2017 •
edited

https://craftcms.stackexchange.com/questions/16066/deferred-redactor-using-clicktoedit-option-opens-a-limited-file-browser-instea

@angrybrad angrybrad added bug severity:minor Cosmetic issues or bugs with simple workarounds labels Jan 28, 2017
@johanneslamers johanneslamers mentioned this issue Feb 1, 2017
Closed
@my2ter my2ter mentioned this issue Feb 1, 2017
Closed
@alambc alambc mentioned this issue Feb 22, 2017
Closed
@brandonkelly brandonkelly self-assigned this Feb 24, 2017
@brandonkelly
Copy link
Member

clickToEdit is preventing Redactor from showing up at all for me. Meh…

leevigraham added a commit to leevigraham/cms that referenced this issue Jun 1, 2017
@leevigraham
Use entry model to get ID rather than variable
2ad1e23 
This fixes an issue where changing the entryType of an existing entry triggers a 500 error:

PHP Notice 'yii\base\ErrorException' with message 'Undefined index: entryId' 

in /Volumes/Sites/Personal/craft3/vendor/craftcms/cms/src/controllers/EntriesController.php:773

Stack trace:
#0 … vendor/yiisoft/yii2/base/InlineAction.php(57): craft\controllers\EntriesController->actionSwitchEntryType()
#1 … vendor/yiisoft/yii2/base/InlineAction.php(57): ::call_user_func_array:{/Volumes/Sites/Personal/craft3/vendor/yiisoft/yii2/base/InlineAction.php:57}('???', '???')
#2 … vendor/yiisoft/yii2/base/Controller.php(156): yii\base\InlineAction->runWithParams('???')
craftcms#3 … vendor/yiisoft/yii2/base/Module.php(523): yii\base\Controller->runAction('???', '???')
craftcms#4 … vendor/craftcms/cms/src/web/Application.php(246): yii\base\Module->runAction('???', '???')
craftcms#5 … vendor/craftcms/cms/src/web/Application.php(385): craft\web\Application->runAction('???', '???')
craftcms#6 … vendor/craftcms/cms/src/web/Application.php(206): craft\web\Application->_processActionRequest('???')
craftcms#7 … vendor/yiisoft/yii2/base/Application.php(380): craft\web\Application->handleRequest('???')
craftcms#8 … web/index.php(33): yii\base\Application->run()
craftcms#9 {main}
brandonkelly pushed a commit that referenced this issue Jun 1, 2017
@leevigraham @brandonkelly
Use entry model to get ID rather than variable
53c6d6c 
This fixes an issue where changing the entryType of an existing entry triggers a 500 error:

PHP Notice 'yii\base\ErrorException' with message 'Undefined index: entryId' 

in /Volumes/Sites/Personal/craft3/vendor/craftcms/cms/src/controllers/EntriesController.php:773

Stack trace:
#0 … vendor/yiisoft/yii2/base/InlineAction.php(57): craft\controllers\EntriesController->actionSwitchEntryType()
#1 … vendor/yiisoft/yii2/base/InlineAction.php(57): ::call_user_func_array:{/Volumes/Sites/Personal/craft3/vendor/yiisoft/yii2/base/InlineAction.php:57}('???', '???')
#2 … vendor/yiisoft/yii2/base/Controller.php(156): yii\base\InlineAction->runWithParams('???')
#3 … vendor/yiisoft/yii2/base/Module.php(523): yii\base\Controller->runAction('???', '???')
#4 … vendor/craftcms/cms/src/web/Application.php(246): yii\base\Module->runAction('???', '???')
#5 … vendor/craftcms/cms/src/web/Application.php(385): craft\web\Application->runAction('???', '???')
#6 … vendor/craftcms/cms/src/web/Application.php(206): craft\web\Application->_processActionRequest('???')
#7 … vendor/yiisoft/yii2/base/Application.php(380): craft\web\Application->handleRequest('???')
#8 … web/index.php(33): yii\base\Application->run()
#9 {main}
@andrelopez andrelopez mentioned this issue Jul 7, 2017
Closed
@andrelopez andrelopez mentioned this issue Aug 30, 2017
Closed
@retop retop mentioned this issue Nov 24, 2017
Closed
@E2design E2design mentioned this issue Dec 8, 2017
Open
@aashish-pixere aashish-pixere mentioned this issue Dec 28, 2017
Closed
@ddbr ddbr mentioned this issue Jan 25, 2018
Closed
@jonlivingston jonlivingston mentioned this issue Jan 26, 2018
Closed
@steveooo9 steveooo9 mentioned this issue Jan 30, 2018
Closed
@Rainbowlemon Rainbowlemon mentioned this issue Feb 14, 2018
Closed
@leigeber leigeber mentioned this issue Feb 21, 2018
Closed
@ryanmasuga ryanmasuga mentioned this issue Feb 28, 2018
Closed
@kr37 kr37 mentioned this issue Mar 20, 2018
Closed
@ghost ghost mentioned this issue Apr 19, 2018
Open
@ul8 ul8 mentioned this issue Jun 20, 2018
Closed
@jamielaughton jamielaughton mentioned this issue Jun 26, 2018
Closed
@AlisherN AlisherN mentioned this issue Jul 26, 2018
Open
@kmmartinez kmmartinez mentioned this issue Aug 21, 2018
Closed
@peteeveleigh peteeveleigh mentioned this issue Oct 10, 2018
Closed
@wsydney76 wsydney76 mentioned this issue May 6, 2022
Closed
@olsp olsp mentioned this issue May 16, 2022
Closed
@richhayler richhayler mentioned this issue May 18, 2022
Closed
@alexr8 alexr8 mentioned this issue Jun 8, 2022
Closed
@Allen-lzr Allen-lzr mentioned this issue Jun 17, 2022
Closed
@FabioIaderosa FabioIaderosa mentioned this issue Jun 20, 2022
Closed
@davola davola mentioned this issue Jun 22, 2022
Closed
@mofman mofman mentioned this issue Jun 25, 2022
Closed
@jamesmacwhite jamesmacwhite mentioned this issue Jul 15, 2022
Closed
@BlizzardWizzard BlizzardWizzard mentioned this issue Jul 25, 2022
Closed
@danfathom danfathom mentioned this issue Sep 13, 2022
Closed
@proimage proimage mentioned this issue Sep 15, 2022
Closed
@MaartenWaegeman MaartenWaegeman mentioned this issue Sep 21, 2022
Closed
@paul-frost paul-frost mentioned this issue Oct 5, 2022
Closed
@swordinthestone swordinthestone mentioned this issue Oct 16, 2022
Closed
@Joorren Joorren mentioned this issue Nov 3, 2022
Closed
@rajparekh-pd rajparekh-pd mentioned this issue Nov 17, 2022
Closed
@alexanderloewe alexanderloewe mentioned this issue Dec 4, 2022
Closed
@bob-pixeldeluxe bob-pixeldeluxe mentioned this issue Dec 7, 2022
Closed
@FabioIaderosa FabioIaderosa mentioned this issue Dec 9, 2022
Closed
@iwfweb iwfweb mentioned this issue Feb 16, 2023
Closed
@joepagan joepagan mentioned this issue Jun 8, 2023
Closed
@leowebguy leowebguy mentioned this issue Aug 25, 2023
Closed
@zzseba78 zzseba78 mentioned this issue Aug 25, 2023
Closed
@moldedjelly moldedjelly mentioned this issue Sep 19, 2023
Closed
@bowen31337 bowen31337 mentioned this issue Oct 5, 2023
Open
@robinbeatty robinbeatty mentioned this issue Oct 31, 2023
Closed
@DTesch-Reem DTesch-Reem mentioned this issue Jan 9, 2024
Closed
@hhentschel hhentschel mentioned this issue Feb 15, 2024
Closed
@LinneaHarts LinneaHarts mentioned this issue Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonkelly brandonkelly

Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @angrybrad