Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aria-describedby to link up inputs to their instructions #7365

Closed
missmatsuko opened this issue Jan 7, 2021 · 1 comment
Closed

Use aria-describedby to link up inputs to their instructions #7365

missmatsuko opened this issue Jan 7, 2021 · 1 comment
Labels
accessibility 👤 features related to accessibility bug
Milestone

Comments

@missmatsuko
Copy link
Contributor

Description

This affects all fields.

Some fields have multiple instructions, in which case the aria-describedby value can be a space-separated list of each instruction element's ID (no hash). For example, the lightswitch field has additional visually-hidden instructions to describe the on/off labels.

Some fields have multiple inputs. e.g. date-time, color. In this case I would suggest attaching the instructions to each user-interactable input.

Matrix is an exception since its instructions would apply to so many inputs... I would leave this as-is for now.

Steps to reproduce

  1. Check if inputs have an aria-describedby attribute with a value of its instruction's ID.

Additional info

  • Craft version: 3.5.17.1
@missmatsuko missmatsuko added bug accessibility 👤 features related to accessibility labels Jan 7, 2021
@brandonkelly brandonkelly added this to the 3.6 milestone Jan 13, 2021
@brandonkelly
Copy link
Member

This is now resolved for Craft 3.6, with the following exceptions:

Matrix is an exception since its instructions would apply to so many inputs... I would leave this as-is for now.

The field container isn’t aware of whether the input is going to be able to provide a more appropriate aria-describedby attribute somewhere, so for now those field types are just not going to get one anymore, which I think is fine since they weren’t getting picked up in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility bug
Projects
None yet
Development

No branches or pull requests

2 participants