Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables #10629

Merged
merged 20 commits into from Apr 19, 2022
Merged

Tables #10629

merged 20 commits into from Apr 19, 2022

Conversation

gcamacho079
Copy link
Contributor

@gcamacho079 gcamacho079 commented Feb 23, 2022

Description

Updates to make table sorting functionality keyboard and screen reader accessible

Related issues

Resolves DEV-214

@gcamacho079 gcamacho079 marked this pull request as ready for review February 23, 2022 21:52
@linear
Copy link

linear bot commented Feb 23, 2022

DEV-214 Update table in element selector modal for keyboard and screen reader accessibility

Requirements:

  • Two visually-hidden live regions should be added: one for selection updates, and another for sorting updates
  • The following changes should be made to the table element:
    • th cells should use the aria-sort attribute, set to either ascending, descending, or none
    • Table rows should not have tabindex="0". Instead, a new column titled "Select" should be added that contains checkboxes, labelled by the element title. For mouse users, a click event on the row should toggle the checkbox
    • Sorting should not be tied to a click on the th. Instead, a button should be nested inside the th
    • A visually-hidden caption element should be added inside the table
      • This caption should specify that columns with button elements are sortable, for example: "Asset selection, column headers with buttons are sortable"

I've created a mockup of the functionality here: https://codepen.io/lupecamacho/full/dyVBMZL

gcamacho079 and others added 2 commits February 24, 2022 09:53
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
@gcamacho079 gcamacho079 requested a review from a team as a code owner March 18, 2022 00:02
@brandonkelly brandonkelly changed the base branch from develop to 4.0 April 18, 2022 23:52
# Conflicts:
#	src/templates/_elements/tableview/container.html
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
@brandonkelly brandonkelly merged commit 46e7cf3 into 4.0 Apr 19, 2022
@brandonkelly brandonkelly deleted the tables branch April 19, 2022 23:47
@gcamacho079 gcamacho079 added the accessibility 👤 features related to accessibility label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants