Strip elisions from search keywords #12474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry-picked your commits to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I learned some things today. The first of which, is that when you smash together some sounds, it's called an elision. They're not very common in English, but they're pretty common in French (they also happen in Catalon, Irish and Italian).
Elisions should be stripped out of search keywords because they change the word and make it harder to find what you're looking for. This fixes that by creating an array of elisions that should be stripped from search terms. I only added the common list in French at the moment, primarily because that's what Elastic search does by default, but we may want to expand this in the future.
Related issues
Fixes #12467