Darken header icon color and (informative) user icon to meet 3:1 cont… #12517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcamacho079
requested review from
benjamindavid,
nfourtythree and
a team
as code owners
gcamacho079
added
accessibility 👤
# Conflicts: # src/web/assets/pluginstore/dist/css/app.css.map # src/web/assets/pluginstore/dist/js/app.js # src/web/assets/pluginstore/dist/js/app.js.map
src/web/assets/cp/src/css/_cp.scss
Outdated
Comment on lines
704
to
709
| box-shadow: 0 0 0 1px transparentize($grey900, 0.95), | ||
| box-shadow: 0 0 0 1px transparentize($grey900, 0.6), | ||
| 0 0 0 transparentize($grey900, 1); | ||
| transition: box-shadow linear 150ms; | ||
|
|
||
| #user-info:hover & { | ||
| box-shadow: 0 0 0 1px transparentize($grey900, 0.95), | ||
| box-shadow: 0 0 0 1px transparentize($grey900, 0.6), |
There was a problem hiding this comment.
Is this change necessary? It looks pretty harsh surrounding the default photo icon, and makes user photos look blurry:
(Existing shadow style on the left; PR style in the right.)
There was a problem hiding this comment.
@brandonkelly it's unnecessary; I was concerned the user SVG might look strange with the original, lighter box shadow, but it actually seems fine. I've reverted it!
# Conflicts: # src/web/assets/cp/dist/images/user.svg # src/web/assets/cp/src/images/user.svg # src/web/assets/pluginstore/dist/css/app.css.map
|
I darkened the user icon as part of #12564 (to be consistent with the folder icons), so looks like this PR isn’t actually necessary anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rast minimum
Description
When a user doesn’t have an account photo set, the account menu — distinguished via the down arrow in conjunction with the user icon — does not meet the minimum contrast of 3:1 for UI components. This PR darkens both the arrow and the user icon fill so that it’s apparent the button relates to a user’s account settings.
Related issues