ensure matrix blocks added on Matrix->inputHtml() are registered as delta changes #12983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
deleted the
bugfix/12973-initial-save-matrix-with-min-blocks
branch
ttempleton
added a commit
to spicywebau/craft-neo
that referenced
this pull request
Jun 2, 2023
internetztube
added a commit
to internetztube/super-table
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have a matrix field with Min Blocks set to at least one, we programmatically add them when rendering the field’s html. However, when the Matrix field is being rendered,
ElementEditoris not yet initialised, so when we get ourinitialSerializedValue()for the editor, the matrix block is already there and then is reported as not changed since the init and therefore not passed to PHP for saving.FYI - not related to the conditionals as suggested by the issue report.
Related issues
#12973