Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force one line logs via env #13544

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Force one line logs via env #13544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b5cddc
Check CRAFT_SINGLE_LINE_LOGS env/constant to force single line logs, …
timkelty Aug 10, 2023
eb6801c
Match language of property
timkelty Aug 11, 2023
3ae64ed
Singular
timkelty Aug 11, 2023
654b83b
Thanks @bencroker
timkelty Aug 14, 2023
bd205c3
Double whoops
timkelty Aug 14, 2023
aa02a92
Clarify condition
timkelty Aug 14, 2023
1afeca6
Merge branch '4.5' into force-one-line-logs
brandonkelly Aug 15, 2023
f25290a
Release note
brandonkelly Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-WIP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@

### System
- Added support for setting environmental values in a “secrets” PHP file, identified by a `CRAFT_SECRETS_PATH` environment variable. ([#13283](https://github.com/craftcms/cms/pull/13283))
- Added support for the `CRAFT_LOG_ALLOW_LINE_BREAKS` environment variable. ([#13544](https://github.com/craftcms/cms/pull/13544))
- All generated URL param characters are now properly encoded. ([#12796](https://github.com/craftcms/cms/issues/12796))
- `migrate` commands besides `migrate/create` no longer create the migration directory if it doesn’t exist yet. ([#12732](https://github.com/craftcms/cms/pull/12732))
- When `content` table columns are resized, if any existing values are too long, all column data is now backed up into a new table, and the overflowing values are set to `null`. ([#13025](https://github.com/craftcms/cms/pull/13025))
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
## Unreleased (4.5)
- Added `craft\events\AssetBundleEvent`.
- Added `craft\web\View::EVENT_AFTER_REGISTER_ASSET_BUNDLE`.
- Added support for the `CRAFT_LOG_ALLOW_LINE_BREAKS` environment variable. ([#13544](https://github.com/craftcms/cms/pull/13544))
- Fixed multiple issues with Selectize inputs.
- Fixed a bug where <kbd>Command</kbd>/<kbd>Ctrl</kbd> + clicks on “New entry” button menu options would open the Entries index page in a new tab, and redirect to the Edit Entry page in the current tab. ([#13550](https://github.com/craftcms/cms/issues/13550))

Expand Down
3 changes: 2 additions & 1 deletion src/log/Dispatcher.php
View file
Open in desktop
brandonkelly marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ public function getTargets(): array
static::TARGET_CONSOLE,
static::TARGET_QUEUE,
])->mapWithKeys(function($name) {
$allowLineBreaks = (bool) (App::env('CRAFT_LOG_ALLOW_LINE_BREAKS') ?? App::devMode());
$config = $this->monologTargetConfig + [
'name' => $name,
'enabled' => false,
'extractExceptionTrace' => !App::devMode(),
'allowLineBreaks' => App::devMode(),
'allowLineBreaks' => $allowLineBreaks,
'level' => App::devMode() ? LogLevel::INFO : LogLevel::WARNING,
];

Expand Down