Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match aria values #14215

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jan 26, 2024

Description

Matches aria values linking tabs.

  • Tab’s aria-controls value now matches the corresponding tabpanel's id.
  • Tabpanel’s aria-labelledby value now matches the corresponding tab’s id.

Related issues

acc-352

Copy link
Contributor

@gcamacho079 gcamacho079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does the trick!

@brandonkelly brandonkelly merged commit 8643da8 into 5.0 Jan 30, 2024
@brandonkelly brandonkelly deleted the feature/acc-352-when-viewing-inline-editable-matrix-blocks-with-tabs-aria branch January 30, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants