New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pa11y audit fixes #7231
Merged
Merged
pa11y audit fixes #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes button-name issues in assets
Fixes label issue in assets
Fixes aria-toggle-field-name issue in assets
Fixes landmark-unique issue in assets
Fixes button-name issue in dashboard
Fixes color-contrast issue in entries
Fixes landmark-unique issue in graphql
Fixes landmark-one-main issue in login
Fixes landmark-unique issues in utilities
Fixes landmark-unique issue in assets settings
Fixes button-name in plugins settings
missmatsuko
force-pushed
the
hotfix/pa11y-audit-fixes
branch
from
December 10, 2020 22:01
0acdc5f
to
52a9e6e
Compare
Fixes duplicate-id issue on email settings
# Conflicts: # src/web/assets/cp/dist/css/craft.css.map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix most of the CP accessibility errors flagged by automated pa11y/axe tests.
The remaining issues are more involved and will be done in other PRs, or need to be fixed in other repos.